On Tue, Feb 04, 2025 at 05:14:48PM -0600, Sami Imseih wrote: > Here are my high-level thoughts on this: > 1. rename queryjumblefuncs.c to jumblefuncs.c
If these APIs are used for somethings else than Query structure, yes, the renaming makes sense. > 2. move the query jumbling related code to parser/analyze.c, > since query jumbling occurs there during parsing. Not sure about this one. It depends on how much is changed. As long as everything related to the nodes stays in src/backend/nodes/, perhaps that's OK. > 3. Rewrite the comments in the new jumblefuncs.c to > make it clear the intention of this infrastructure; that > it is used to jumble nodes for query or plan trees. Seems to me that this could be done before 2, as well. > I can work on this if you agree. I'd welcome an extra patch to rework a bit the format of the comments for the Plan nodes, to ease the addition of pg_node_attr(), making any proposed patches more readable. -- Michael
signature.asc
Description: PGP signature
