Hi, On 2025-01-30 16:18:54 +0300, Nazir Bilal Yavuz wrote: > On Wed, 29 Jan 2025 at 19:50, Andres Freund <and...@anarazel.de> wrote: > > I don't think that's the entirety of the issue. > > > > Our dependencies aren't quite airtight enough. With a sufficiently modern > > meson, try doing e.g. > > > > rm -rf tmp_install/ && ninja clean && meson test --suite setup --suite > > ecpg > > > > It'll fail, because the dependencies of the tests are insufficient. > > > > See the set of patches at > > https://www.postgresql.org/message-id/qh4c5tvkgjef7jikjig56rclbcdrrotngnwpycukd2n3k25zi2%4044hxxvtwmgum > > > > > > I think the only reason your patch on its own suffices, is that the "all" > > target, that we ran separately beforehand, actually has sufficient > > dependencies to make things work. > > Yes, you are right. I agree that what you said is the correct solution > and that should be the ultimate goal.
I think we need to fix this properly across branches. The version of meson is going to be more common soon. And it'll be a problem for developers too, not just CI. I'll start working on committing these fixes across the branches, unless somebody protests immediately. > What I shared could be a band-aid fix to make the Windows CI task happy > until the patches you shared get committed. I think we'll still need something like what you propose. Although I do think it'd be better if we continued building all targets in a dedicated _script: block, so that you can see all build failures in those steps. Greetings, Andres Freund
