On Mon, Jan 13, 2025 at 3:26 PM Alena Rybakina <a.rybak...@postgrespro.ru> wrote: > I noticed that the cfbot is bad, the reason seems to be related to the lack > of a parameter in src/backend/utils/misc/postgresql.conf.sample. I added it, > it should help.
The patch doesn't apply cleanly. Please rebase. I see you introduced new GUC variable pgstat_track_vacuum_statistics, which should address the increased size of statistics. However, I don't see how it could affect the size of PgStat_StatTabEntry struct. It seems that when pgstat_track_vacuum_statistics == 0, extended vacuum statistics is not collected but the size of hash table entries is the same. Also, should pgstat_track_vacuum_statistics also affect per database statistics? The name of 0001 is "... on heap relations". Should we say "on table relations", because new machinery should work with alternative table AMs as well. There are deletions of empty lines in src/include/utils/pgstat_internal.h and src/include/pgstat.h. Please, remote them as it's not purpose of this patchset. ------ Regards, Alexander Korotkov Supabase
