On Wed, Jan 22, 2025 at 4:24 PM Melanie Plageman <melanieplage...@gmail.com> wrote: > > On Mon, Dec 9, 2024 at 1:22 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > Are we planning to commit this refactoring? I think this refactoring > > makes the overall code of BitmapHeapNext() quite clean and readable. > > I haven't read all patches but 0001-0006 including 0009 makes this > > code quite clean and readable. I like the refactoring of merging of > > the shared iterator and the private iterator also. > > Thanks for the feedback, Dilip. I've pushed the patches through 0006. > > I've reorganized the remaining patches in attached v26. > > 0001 is just the refactoring to push the setup into a helper. > 0002-0003 are required refactoring of the TBMIterateResult and > TBMIterator to support the read stream API. > 0004 implements using the read stream API and removing the old prefetching > code. > 0005 removes the table_scan_bitmap_next_block() callback, as it is not > really used anymore in BitmapHeapNext() to get the next block. > > I could use review feedback on all of them. 0001 should be ready to > push once I get some review.
Bilal mentioned offlist that 0001 had some indentation issues in one of the comments. v27 attached. - Melanie
v27-0004-BitmapHeapScan-uses-read-stream-API.patch
Description: Binary data
v27-0003-Separate-TBM-Shared-Private-Iterator-and-TBMIter.patch
Description: Binary data
v27-0002-Hard-code-TBMIterateResult-offsets-array-size.patch
Description: Binary data
v27-0005-Remove-table-AM-callback-scan_bitmap_next_block.patch
Description: Binary data
v27-0001-Move-BitmapTableScan-per-scan-setup-into-a-helpe.patch
Description: Binary data
