On Thu, Jan 23, 2025 at 6:35 PM Mahendra Singh Thalor <mahi6...@gmail.com> wrote: > > On Thu, 23 Jan 2025 at 14:59, jian he <jian.universal...@gmail.com> wrote: > > > > hi. > > The four patches attached are to solve the > > TODO1: We need to think for --exclude-database=PATTERN for pg_restore. > > it is based on your > > v11_pg_dumpall-with-directory-tar-custom-format-21-jan.patch > > > > > > 0001. pg_dumpall --exclude-database=PATTERN already works, > > main function resolve pattern matching is expand_dbname_patterns. > > make it an extern function, so pg_restore --exclude-database can also use > > it. > > Hi Jian, > We can't use the same expand_dbname_patterns function pg_restore. > > In the 1st patch, by mistake I also used this function but then I > realised that we should not use this function due to some limitation > for pg_restore. > > While doing pg_dumpall, we have all the existence database names in > the pg_database catalog but while restoring, we don't have all > databases in the catalog. > Actually, we will read dbnames from map.dat file to skip matching > patterns for restore. >
hi. After some tests and thinking about your reply, I admit that using expand_dbname_patterns in pg_restore will not work. We need to do pattern matching against the map.dat file. Please check the attached v12 series based on your v11_pg_dumpall-with-directory-tar-custom-format-21-jan.patch v12-0001 cosmetic change. v12-0002 implement pg_resore --exclude-database=PATTERN. main gist of implementation: for each database name in map.dat file, check if this database name pattern matches with PATTERN or not. pattern matching is using processSQLNamePattern. your substring will not work. some of the test cases. $BIN10/pg_restore --exclude-database=* -Cd template1 --verbose dir10 > dir_format 2>&1 $BIN10/pg_restore --exclude-database=*x* -Cd template1 --verbose dir10 > dir_format 2>&1 $BIN10/pg_restore --exclude-database=?* -Cd template1 --verbose dir10 > dir_format 2>&1
v12-0002-pg_restore-exclude-database-PATTERN.no-cfbot
Description: Binary data
v12-0001-coesmetic-change.no-cfbot
Description: Binary data
