On Thu, Jan 23, 2025 at 10:33 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > On Wed, Jan 22, 2025 at 7:29 PM Shubham Khanna > <khannashubham1...@gmail.com> wrote: > > > > Hi all, > > > > I am writing to propose an enhancement to the pg_createsubscriber > > utility that enables it to automatically fetch all non-template > > databases from the publisher when no specific databases are specified > > by the user. This was an open item from [1] that was planned for > > future implementation. The attached patch has the changes for the > > same. > > I think the feature will be useful, but UI might cause some unwanted > results. If a user forgets to specify -d option, the utility will > create subscriptions to all the databases, some of which may or may > not have the publications. I think it's better to provide an option to > specify all databases explicitly (e.g. --all-databases). >
+1 better to be safe. Instead of a new switch, how about changing the --database switch to accept a pattern (like pg_dump --schema does [1]) Then "all databases" would be specified something like --database = * ====== [1] https://www.postgresql.org/docs/current/app-pgdump.html Kind Regards, Peter Smith. Fujitsu Australia
