Hi Peter, Peter Smith <smithpb2...@gmail.com> writes:
> Hi, > > In your v4 patch, there is a fragment (below) that replaces a double > '--verbose' switch with just a single '--verbose'. > > As I have only recently learned, the '--verbose'' switch has a > cumulative effect [1], so the original double '--verbose' was probably > deliberate so it should be kept that way. I was going to say that if it were deliberate, I would have expected the two `--verbose` swithces to be together, but then I noticed that the --recovery-timeout switch was added later (commit 04c8634c0c4d), rather haphazardly between them. Still, I would have expected a comment as to why this command was being invoked extra-verbosely, but I'll restore it in the next version. I've Cc-ed both Peter (the committer) and Euler (the author) in case they have any insight. > ~~ > > # Run pg_createsubscriber on node S > command_ok( > [ > - 'pg_createsubscriber', '--verbose', > - '--recovery-timeout', "$PostgreSQL::Test::Utils::timeout_default", > - '--verbose', '--pgdata', > - $node_s->data_dir, '--publisher-server', > - $node_p->connstr($db1), '--socketdir', > - $node_s->host, '--subscriber-port', > - $node_s->port, '--publication', > - 'pub1', '--publication', > - 'Pub2', '--replication-slot', > - 'replslot1', '--replication-slot', > - 'replslot2', '--database', > - $db1, '--database', > - $db2 > + 'pg_createsubscriber', > + '--verbose', > + '--recovery-timeout' => $PostgreSQL::Test::Utils::timeout_default, > + '--pgdata' => $node_s->data_dir, > + '--publisher-server' => $node_p->connstr($db1), > + '--socketdir' => $node_s->host, > + '--subscriber-port' => $node_s->port, > + '--publication' => 'pub1', > + '--publication' => 'pub2', > + '--replication-slot' => 'replslot1', > + '--replication-slot' => 'replslot2', > + '--database' => $db1, > + '--database' => $db2, > ], > 'run pg_createsubscriber on node S'); > > > ====== > [1] https://www.postgresql.org/docs/devel/app-pgcreatesubscriber.html > > Kind Regards, > Peter Smith. > Fujitsu Australia
