On Mon, Jan 20, 2025 at 12:00 PM Peter Smith <smithpb2...@gmail.com> wrote: > > Hi Shubham, > > Patch v12-0001 LGTM. > > BTW, there is a precedent for passing the 'opt' arg but then only > using one member from it. See function wait_for_end_recovery in this > same file. So whether you decide to change the code per Shlok's review > [1], or decide not to change it -- either way is OK for me. > > ====== > [1] > https://www.postgresql.org/message-id/CANhcyEXQ1h%3DoSPFFziCZuU6far6a82DQafL0S85CyVRyEntA%2Bw%40mail.gmail.com >
I have incorporated Shlok's suggestion [1] into the patch and made the necessary updates. The attached v13 patch at [2] contains the updated changes. [1] https://www.postgresql.org/message-id/CANhcyEXQ1h%3DoSPFFziCZuU6far6a82DQafL0S85CyVRyEntA%2Bw%40mail.gmail.com [2] https://www.postgresql.org/message-id/CAHv8RjJfaHFMeDkHOdMpLUHCeDN%2Be5p0CsdQxcKEOiWRnRjxfg%40mail.gmail.com Thanks and regards, Shubham Khanna.
