Hi Vignesh,
Thanks for including my patch in your patch set, ensuring that it does
not get left behind.
1.
These docs are mostly still OK, but have become slightly stale because:
a) they should mention "stored" in some places
b) the examples now need to be using the new enum form of the
publication option introduced in your patch 0003
~~~
2.
Fixed a typo /explicty/explicitly/
======
I've attached a top-up patch to "fix" all issues I found for the
v53-0005 docs patch. Please have a look and apply them if they seem OK
to you.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
diff --git a/doc/src/sgml/logical-replication.sgml
b/doc/src/sgml/logical-replication.sgml
index e4f5d84..e39771d 100644
--- a/doc/src/sgml/logical-replication.sgml
+++ b/doc/src/sgml/logical-replication.sgml
@@ -1664,24 +1664,24 @@ test_sub=# SELECT * from tab_gen_to_gen;
<para>
Generated columns are not published by default, but users can opt to
- publish generated columns just like regular ones.
+ publish stored generated columns just like regular ones.
</para>
<para>
There are two ways to do this:
<itemizedlist>
<listitem>
<para>
- Enable the <command>PUBLICATION</command> parameter
+ Set the <command>PUBLICATION</command> parameter
<link
linkend="sql-createpublication-params-with-publish-generated-columns">
- <literal>publish_generated_columns</literal></link>. This instructs
- PostgreSQL logical replication to publish current and future generated
- columns of the publication's tables.
+ <literal>publish_generated_columns</literal></link> to
<literal>stored</literal>.
+ This instructs PostgreSQL logical replication to publish current and
+ future stored generated columns of the publication's tables.
</para>
</listitem>
<listitem>
<para>
Specify a table <link linkend="logical-replication-col-lists">column
list</link>
- to explicity nominate which generated columns will be published.
+ to explicitly nominate which stored generated columns will be published.
</para>
<note>
<para>
@@ -1701,7 +1701,7 @@ test_sub=# SELECT * from tab_gen_to_gen;
<para>
The following table summarizes behavior when there are generated columns
involved in the logical replication. Results are shown for when
- publishing generated columns is disabled (default), and for when it is
+ publishing generated columns is not enabled, and for when it is
enabled.
</para>
<table id="logical-replication-gencols-table-summary">
@@ -1791,12 +1791,12 @@ CREATE TABLE
<para>
Create the <literal>PUBLICATION</literal> and the
<literal>SUBSCRIPTION</literal>.
Note that the publication specifies a column list for table
<literal>t2</literal>.
- The publication also sets parameter
<literal>publish_generated_columns=false</literal>,
- but that is just for demonstration because <literal>false</literal> is the
+ The publication also sets parameter
<literal>publish_generated_columns=none</literal>,
+ but that is just for demonstration because <literal>none</literal> is the
default anyway.
<programlisting>
test_pub=# CREATE PUBLICATION pub1 FOR TABLE t1, t2(a,c)
-test_pub-# WITH (publish_generated_columns=false);
+test_pub-# WITH (publish_generated_columns=none);
CREATE PUBLICATION
</programlisting>
<programlisting>
@@ -1846,12 +1846,12 @@ test_sub=# SELECT * FROM t1;
</para></listitem>
<listitem><para>
<literal>t1.c</literal> is a generated column. It is not replicated because
- <literal>publish_generated_columns=false</literal>. The subscriber
+ <literal>publish_generated_columns=none</literal>. The subscriber
<literal>t2.c</literal> default column value is used.
</para></listitem>
<listitem><para>
<literal>t1.d</literal> is a generated column. It is not replicated because
- <literal>publish_generated_columns=false</literal>. The subscriber
+ <literal>publish_generated_columns=none</literal>. The subscriber
<literal>t2.d</literal> generated column value is used.
</para></listitem>
</itemizedlist>
