Hi, I apologize for the late response. I completely missed tracking updates on this thread.
On Tue, Nov 19, 2024 at 5:28 PM Noah Misch <n...@leadboat.com> wrote: > > On Thu, Oct 03, 2024 at 06:55:47AM -0700, Masahiko Sawada wrote: > > I've attached PoC patches for the idea Noah proposed. Newly created > > clusters unconditionally have default_char_signedness=true, and the > > only source of signedness=false is pg_upgrade. To update the > > signedness in the controlfile, pg_resetwal now has a new option > > --char-signedness, which is used by pg_upgrade internally. Feedback is > > very welcome. > > Upthread, we discussed testability. Does pg_resetwal facilitate all > appropriate testing, or do testing difficulties remain? I think the new pg_resetwal facility to change the cluster's char signedness is useful for testing. We can easily test cross architecture replication from now on. > > I reviewed these patches, finding only one non-cosmetic review comment. Given > the PoC status, some of the observations below are likely ones you already > know or would have found before exiting PoC. Thank you for reviewing the patches. I agree with all the comments you made. I've addressed them and I've attached new version patches that now have some regression tests. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
v3-0004-pg_upgrade-Add-set-char-signedness-to-set-the-def.patch
Description: Binary data
v3-0005-Fix-an-issue-with-index-scan-using-pg_trgm-due-to.patch
Description: Binary data
v3-0003-pg_upgrade-Preserve-default-char-signedness-value.patch
Description: Binary data
v3-0002-pg_resetwal-Add-char-signedness-option-to-change-.patch
Description: Binary data
v3-0001-Add-default_char_signedness-field-to-ControlFileD.patch
Description: Binary data
