On Thu, Oct 10, 2024 at 1:56 AM Shinya Kato <shinya11.k...@oss.nttdata.com> wrote: > Thank you all for the comments! <snip> > While adding to the documentation is sufficient if users use it > correctly, users often behave unexpectedly. My intention was to > implement it in a way that works without issues even if misused. > However, since the prevailing opinion seems to favor simply updating the > documentation, I will proceed with that approach. > > A new patch is attached. > I am not a native English, so corrections to the texts are welcome. >
This looks pretty good to me. I think there are a couple of minor grammar changes that could be made, and I think the pg_dumpall section could use a couple tweaks, specifically 1) not all incantations of pg_dumpall emit psql meta commands (-g comes to mind quickly) and ISTR some non-psql clients honor psql meta commands, so I would lessen the language around incompatibility, and 2) I think adding an explicit -f for the database name in the pg_dumpall is clearer, and mirrors the pg_dump example. suggested diffs attached, let me know if you would like a consolidated patch Robert Treat https://xzilla.net
xzilla-pg_dump-no-psqlrc.diff
Description: Binary data
