Hi, On 2025-01-09 16:50:45 +0300, Nazir Bilal Yavuz wrote: > On Wed, 8 Jan 2025 at 22:26, Andres Freund <and...@anarazel.de> wrote: > === 0005 > > > I think this is much better than before. I don't love PM_WAIT_XLOG_ARCHIVAL, > > but I can't think of anything better. > > I liked this, I think it is good enough. > > - PM_SHUTDOWN, /* waiting for checkpointer to do shutdown > + PM_WAIT_XLOG_SHUTDOWN, /* waiting for checkpointer to do shutdown > * ckpt */ > > There are couple of variables and functions which include pm_shutdown > in their names: > pending_pm_shutdown_request > handle_pm_shutdown_request_signal() > process_pm_shutdown_request() > > Do you think these need to be updated as well?
I don't think so - I think those are actually not specifically referencing the PM_SHUTDOWN symbol. They're referencing shutting down postmaster - which neither starts nor ends with PM_SHUTDOWN. Greetings, Andres Freund