On Tue, Jan 7, 2025 at 6:56 AM Matthias van de Meent <boekewurm+postg...@gmail.com> wrote: > Apart from comments on comment contents and placement, no specific issues:
Pushed this just now. Thanks for the review! > > + * > > + * Initialize arrays during first (unscheduled) primitive index scan. > > + */ > > I think this could be more clear about why these conditions indicate > the first unscheduled primitive index scan. Improved this in the committed patch. > I don't understand the placement of that comment, as it's quite far > away from any parallel scan related code and it's very unrelated to > the index scan statistics. > If this needs to be added, I think I'd put it next to the call to > _bt_parallel_seize(). Done that way in the committed patch. -- Peter Geoghegan