Re: Sample rate added to pg_stat_statements

[Andrey M. Borodin]

> On 6 Jan 2025, at 15:50, Ilia Evdokimov <ilya.evdoki...@tantorlabs.com> wrote:
> 
> Any suggestions for improvements?

The patch looks good to me, just a few nits.

0. Perhaps, we could have a test for edge values of 0 and 1. I do not insist, 
just an idea to think about.

1. This code seems a little different from your patch. It is trying to avoid 
engaging PRNG. I'm not sure it's a good idea, but still. Also, it uses "<=", 
not "<".

    xact_is_sampled = log_xact_sample_rate != 0 &&
(log_xact_sample_rate == 1 ||
pg_prng_double(&pg_global_prng_state) <= log_xact_sample_rate);

Thanks!


Best regards, Andrey Borodin.