While working on this: https://www.postgresql.org/message-id/20230625.210509.1276733411677577841.t-ishii%40sranhm.sra.co.jp
I noticed that WinGetFuncArgInFrame() in nodeWindowAgg.c is hard to read/understand. I think part of the reason is, it is long and has large switch case and uses goto. I propose to refactor the function to mitigate the issue. With attached patch, the large switch case is moved to a new static function WinGetSlotInFrame(). Best reagards, -- Tatsuo Ishii SRA OSS K.K. English: http://www.sraoss.co.jp/index_en/ Japanese:http://www.sraoss.co.jp
v1-0001-Refactor-WinGetFuncArgInFrame.patch
Description: Binary data
