Hi hackers,
I've attached a small patch that remove unused parameter 'rel' from
the static function lookup_var_attr_stats() in extended_stats.c
While exploring src/backend/statistics, I noticed that there are several
other parameters which appear to be unused. However, since the
discussion around import/export statistics [1] attribute_stats.c is
still ongoing and many functions from other files are non-static, those
parameters may yet prove useful. Therefore, I'm only removing the
parameter from this static function.
Any thoughts?
[1]:
https://www.postgresql.org/message-id/flat/CADkLM%3DcB0rF3p_FuWRTMSV0983ihTRpsH%2BOCpNyiqE7Wk0vUWA%40mail.gmail.com
--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.
From a59af002463c962f153c79202b5f091a24fa6199 Mon Sep 17 00:00:00 2001
From: Ilia Evdokimov <ilya.evdoki...@tantorlabs.com>
Date: Fri, 3 Jan 2025 16:46:51 +0300
Subject: [PATCH] Remove unused rel parameter in lookup_var_attr_stats
The rel parameter in lookup_var_attr_stats is unused, so remove it.
This is a static function, so the parameter can easily be added again if
it's ever needed.
---
src/backend/statistics/extended_stats.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backend/statistics/extended_stats.c b/src/backend/statistics/extended_stats.c
index aeec3ece41..34dcb535e1 100644
--- a/src/backend/statistics/extended_stats.c
+++ b/src/backend/statistics/extended_stats.c
@@ -74,7 +74,7 @@ typedef struct StatExtEntry
static List *fetch_statentries_for_relation(Relation pg_statext, Oid relid);
-static VacAttrStats **lookup_var_attr_stats(Relation rel, Bitmapset *attrs, List *exprs,
+static VacAttrStats **lookup_var_attr_stats(Bitmapset *attrs, List *exprs,
int nvacatts, VacAttrStats **vacatts);
static void statext_store(Oid statOid, bool inh,
MVNDistinct *ndistinct, MVDependencies *dependencies,
@@ -165,7 +165,7 @@ BuildRelationExtStatistics(Relation onerel, bool inh, double totalrows,
* Check if we can build these stats based on the column analyzed. If
* not, report this fact (except in autovacuum) and move on.
*/
- stats = lookup_var_attr_stats(onerel, stat->columns, stat->exprs,
+ stats = lookup_var_attr_stats(stat->columns, stat->exprs,
natts, vacattrstats);
if (!stats)
{
@@ -293,7 +293,7 @@ ComputeExtStatisticsRows(Relation onerel,
* analyzed. If not, ignore it (don't report anything, we'll do that
* during the actual build BuildRelationExtStatistics).
*/
- stats = lookup_var_attr_stats(onerel, stat->columns, stat->exprs,
+ stats = lookup_var_attr_stats(stat->columns, stat->exprs,
natts, vacattrstats);
if (!stats)
@@ -687,7 +687,7 @@ examine_expression(Node *expr, int stattarget)
* indicate to the caller that the stats should not be built.
*/
static VacAttrStats **
-lookup_var_attr_stats(Relation rel, Bitmapset *attrs, List *exprs,
+lookup_var_attr_stats(Bitmapset *attrs, List *exprs,
int nvacatts, VacAttrStats **vacatts)
{
int i = 0;
--
2.34.1
