On Mon, Dec 16, 2024 at 05:25:45PM +0800, jian he wrote: > i've split into 3 patches, feel free to merge them in any way. > v12-0001: add error position for ATPrepAlterColumnType.
For this one, why don't you do the same for undefined columns and USING with generated columns at least? This looks half-baked. > v12-0002: add error position for these 3 functions: > transformColumnDefinition, transformAlterTableStmt, transformTableConstraint. ERROR: column "c" of relation "itest4" does not exist +LINE 1: ALTER TABLE itest4 ALTER COLUMN c ADD GENERATED ALWAYS AS ID... + ^ This one is kind of confusing? The part that matters for the error is the column that does not exist, not the ADD GENERATED. ERROR: conflicting NO INHERIT declarations for not-null constraints on column "a" +LINE 1: ..._tbl_fail (a int generated by default as identity not null n... + ^ This one also, is kind of hard-ish to act on.. > v12-0003: add error position for these 2 functions: > DefineType, transformOfType This one has been applied as of 0f23dedc9176. -- Michael
signature.asc
Description: PGP signature
