On Tue, Dec 24, 2024 at 02:06:26PM +0100, Michail Nikolaev wrote: > Now STIR used for validation (but without resetting of snapshot during > that phase for now).
Perhaps I am the only one, but what you are doing here is confusing. There is a dependency between one patch and the follow-up ones, but while the first patch is clear regarding its goal of improving the interactions between REINDEX CONCURRENTLY and INSERT ON CONFLICT regarding the selection of arbiter index in the executor in 0001 in the scope of the other thread you have created about this problem, it is unclear what's the goal of what you are trying to do with 0003~, if any of the follow-up patches help with that, and even why they have a need to be posted on this thread. So perhaps you should split things and explain what your goals are for each patch, or articulate better why things are done this way? It looks like more things just keep piling each time a new patch series is sent to the lists. Posting 300kB worth of patches every 3 days is not going to help potential reviewers, just confuse them. Note that 0002, that attempts to introduce new tests, is costly. This is not acceptable for integration. I'd suggest to replace that with tests that have controlled and successive steps as these lead to predictible results, rather than have something that runs an arbitrary amount of time to stress the friction of concurrent activity (this is still useful to prove your point, though). That's something related to the other thread, but in passing.. -- Michael
signature.asc
Description: PGP signature
