Hi, I noticed that the MD smgr internals misbehave when unlink requests for specific forks or specific segments are sent through SyncOps, as it currently always unlinks segment 0 of the main fork, even if only a different fork and/or segment was requested.
While probably not extremely critical, it seems bad to not unlink the right segment while in recovery, so here's a patch that unlinks the exact requested files. The unlinking of forks in the FileTag infrastructure has been broken since b0a55e43 in PG16, while a segment number other than 0 has never been unlinked (at least not since the introduction of the system with 3eb77eba in PG12). However, extensions may still make use of this and incorrectly assume that only the requested file of the requested fork 's segment will be unlinked, when it actually unlinks data from the main fork. The attached fixes that for PG16+. PG13-15 will take a little bit more effort due to code changes in PG16; though it'd probably still require a relatively minor change. Kind regards, Matthias van de Meent. Neon (https://neon.tech)
v1-0001-MD-smgr-Unlink-the-requested-file-segment-not-mai.patch
Description: Binary data
