On 12/5/24 1:21 AM, Jeff Davis wrote:
= v9-0003-Move-code-for-collation-version-into-provider-spe.patch
Moves some code from pg_collate.c into provider specific files.
I agree with the general idea, but it seems we are accumulating a lot
of provider-specific functions. Should we define a provider struct with
its own methods?
That would be a good step toward making the provider catalog-driven.
Even if we don't support CREATE LOCALE PROVIDER, having space in the
catalog would be a good place to track the provider version.
Yeah, that was my idea too but I just have not gotten around to it yet.
= v9-0004-Move-ICU-database-encoding-check-into-validation-.patch
This seems to be causing a test failure in 020_createdb.pl.
Thanks, I have attached a fixup commit for this.
Andreas
From ccaaf785a2aa14460d8360709d6f0ea4746f0157 Mon Sep 17 00:00:00 2001
From: Andreas Karlsson <andr...@proxel.se>
Date: Fri, 20 Dec 2024 06:47:33 +0100
Subject: [PATCH] fixup! Move ICU database encoding check into validation
function
---
src/bin/scripts/t/020_createdb.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/bin/scripts/t/020_createdb.pl b/src/bin/scripts/t/020_createdb.pl
index 4a0e2c883a1..36d285d4777 100644
--- a/src/bin/scripts/t/020_createdb.pl
+++ b/src/bin/scripts/t/020_createdb.pl
@@ -59,7 +59,7 @@ if ($ENV{with_icu} eq 'yes')
$node->command_fails_like(
[
'createdb', '-T',
- 'template0', '--locale-provider=icu',
+ 'template0', '--locale-provider=icu', '--icu-locale=en',
'--encoding=SQL_ASCII', 'foobarX'
],
qr/ERROR: encoding "SQL_ASCII" is not supported with ICU provider/,
--
2.45.2
