On Thu, Dec 19, 2024, at 07:48, jian he wrote: > I have reviewed v21-0001 again. > > v21-0001-Introduce-CopyFormat-and-replace-csv_mode-and-binary.patch > is a good refactor. > > > overall looks good to me.
OK, I could submit it as a separate patch. Would we also want the reorganization of existing copy option validations? That is, v21-0003-Reorganize-option-validations.patch minus v21-0002-Add-COPY-format-list.patch. Nice that you managed to arrange them in the same order as in the documentation. Made the code easier to follow. /Joel