On Thu, Dec 19, 2024 at 07:50:57AM +0530, Amit Kapila wrote: > The difference between fix_memory_leak_v2 and fix_memory_leak_v3 is > that the earlier one resets the pubctx to NULL along with freeing the > context memory. Resetting a file-level global variable is a good idea, > similar to what we do for RelationSyncCache, so I prefer v2 over v3, > but I am fine if you would like to proceed with v3.
FWIW, I am not OK with v3. I've raised this exact point a couple of days ago upthread: https://www.postgresql.org/message-id/z1t5pxsneyws4...@paquier.xyz v2 does not have these weaknesses by design. -- Michael
signature.asc
Description: PGP signature
