On Mon, Dec 16, 2024 at 10:57:49PM +0100, Michael Banck wrote: > Thanks, I have added the documentation now in v2.
The doc additions seem fine to me. I've just grabbed three tiny nits, nothing critical. + case 's': + if (PQservice(pset.db)) + strlcpy(buf, PQservice(pset.db), sizeof(buf)); + break; Other code paths of get_prompt check for pset.db being NULL. True that it does not matter when calling PQservice() with a connection that does not exist. For consistency with the surroundings this should be done at least? + <para> + The service from <filename>pg_service.conf</filename>, if applicable. + </para> pg_service.conf is not especially true as it depends on the environment used. For psql, perhaps just use "The service name, if applicable". No need to be fancy. --- a/src/interfaces/libpq/exports.txt +++ b/src/interfaces/libpq/exports.txt @@ -205,3 +205,4 @@ PQcancelFinish 202 [...] +PQservice 206 You didn't miss that, nice. + <varlistentry id="app-psql-prompting-s"> + <term><literal>%s</literal></term> + <listitem><para>The name of the service entry, if any.</para></listitem> + </varlistentry> Other entries don't use "if any", would just cut it. -- Michael
signature.asc
Description: PGP signature
