"Tels" <nospam-pg-ab...@bloodgate.com> writes: > Looking at your new patch, I notice you used "" for quoting, not ''. (Not > sure which variant Tom used when pushing a patch). > I'm not a shell expert, but I think '' are safer, as "" still has some > interpolation from the shell (at least on the systems I use regulary):
We can't do that here because '' would suppress interpolation of the variable's value, which is sort of the point. AFAIK, the locution "$foo" is safe regardless of what is in $foo, as long as only one pass of shell evaluation is involved. The shell will treat the value of $foo as one not-further-interpreted command argument. regards, tom lane