On Mon, 2 Dec 2024 at 17:22, jian he <jian.universal...@gmail.com> wrote: > regarding v10. > you placed remove_useless_groupby_columns right after add_base_rels_to_query > makes so much sense. > so we can be safely use cached RelOptInfo->indexlist, > RelOptInfo->notnullattnums > overall it didn't find any issue.
Thanks for looking. After a bit more adjustment, I've pushed both patches. I felt it was best to have the commit that moved remove_useless_groupby_columns also change the call site of that function. David