Andrei Lepikhov <lepi...@gmail.com> writes: > It makes sense. But I want to clarify that I avoided changing > PG_MODULE_MAGIC because the newly introduced structure has a totally > different purpose and usage logic: the struct is designed to check > compatibility, but module info isn't connected to the core version at > all: a single version of the code may be built for multiple PG versions. > At the same time, various versions of the same library may be usable > with the same core.
Surely. But I don't see a need for two separately-looked-up physical structures. Seems to me it's sufficient to put the ABI-checking fields into a sub-struct within the magic block. regards, tom lane