Hi all, While browsing through the code, I have noticed two comments on top of assign_timezone_abbreviations() and check_timezone_abbreviations() that mention "assign_timezone_abbreviations" as the GUC name, while it should be "timezone_abbreviations", obviously.
I have not noticed any similar mistakes for the other check and assign hooks. Comments are welcome. -- Michael
diff --git a/src/backend/commands/variable.c b/src/backend/commands/variable.c index 2c8059e8d8..d2db0c45b2 100644 --- a/src/backend/commands/variable.c +++ b/src/backend/commands/variable.c @@ -479,7 +479,7 @@ show_log_timezone(void) */ /* - * GUC check_hook for assign_timezone_abbreviations + * GUC check_hook for timezone_abbreviations */ bool check_timezone_abbreviations(char **newval, void **extra, GucSource source) @@ -511,7 +511,7 @@ check_timezone_abbreviations(char **newval, void **extra, GucSource source) } /* - * GUC assign_hook for assign_timezone_abbreviations + * GUC assign_hook for timezone_abbreviations */ void assign_timezone_abbreviations(const char *newval, void *extra)
signature.asc
Description: PGP signature