On Thu, Dec 05, 2024 at 07:37:27AM +0000, Bertrand Drouvot wrote:
> That said, I think that's worth to update the comment a bit (like in the
> attached?) as I think that answers a legitimate question someone could have 
> while
> reading this code.
>  
> -             /* we may have some "dropped" entries not yet removed, skip 
> them */
> +             /*
> +              * We may have some "dropped" entries not yet removed, skip 
> them as
> +              * it's not worth taking down the server for this.
> +              */

Perhaps this should provide some details, like the fact that we don't
expect the server to still have references to entries that are dropped
at shutdown when writing the stats file as all the backends and/or
auxiliary processes should have done this cleanup before they are
gone.
--
Michael

Attachment: signature.asc
Description: PGP signature

Reply via email to