On Tuesday, December 3, 2024 4:43 AM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2024-Dec-02, Amit Kapila wrote: > > > you call anything that loads a Publication depending on how the > > > caller caches its data. So I would still choose for modifying the > > > structure on HEAD removing the pstrdup() for the publication name. > > > > BTW, the subscription structure also used the name in a similar way. > > This will make the publication/subscription names handled differently. > > True (with conninfo, slotname, synccommit, and origin). ... > > (Why are we storing a string in Subscription->synccommit?)
I think it's because the primary purpose of sub->synccommit is to serve as a parameter for SetConfigOption() in the apply worker, which requires a string value. Additionally, the existing function set_config_option() that validates this option only accepts a string input. Although we could convert sub->synccommit to an integer, this would necessitate additional conversion code before passing it to these functions. Best Regards, Hou zj
