Hello Alvaro, Monday, November 25, 2024, 10:51:31 PM, you wrote:
AH> Hmm, I think if we believe this to be really possible, we should have an AH> 'if/elog' test (or maybe a full ereport with ERRCODE_DATA_CORRUPTED AH> errcode) rather than an assertion. I think the assertion adds nothing AH> of value here, but maybe an 'if' test would. I don't mind of 'if' however it's not clear for me what to follow on other (error) branch of that 'if'. AH> Did you examine the other callers of PageGetMaxOffsetNumber()? It's a AH> large bunch. Mostly it used in loops. So some code will be gracefully skipped and that's it. However the case discussed is different because -1 index of an array will be accessed. Which is much worse than a bare assertion at least. -- Best regards, Dmitry mailto:pgsql-hack...@dima.nikitin.name
