Hi, Here are my review comments for patch v9-0001. These are only trivial nits for some code comments. Everything else looked good to me.
====== .../replication/logical/reorderbuffer.c ReorderBufferTruncateTXN: 1. + * The given transaction is marked as streamed if appropriate and the caller + * asked it by passing 'mark_txn_streaming' being true. /asked it/requested it/ /being true/as true/ ~~~ ReorderBufferPrepare: 2. + /* + * Remember if the transaction is already aborted to check if we detect + * that the transaction is concurrently aborted during the replay. + */ SUGGESTION: Remember if the transaction is already aborted so we can detect when the transaction is concurrently aborted during the replay. ====== Kind Regards, Peter Smith. Fujitsu Australia
