Hi,

On 2024-11-21 14:24:26 +1300, Thomas Munro wrote:
> Oh, and yeah, we should include the branch name in the cache key.
> Something like the attached.

I think that'd be too granular - we'd end up with lots of copies of
effectively the same cache, but which won't exactly the same due to timestamps
and such.


> I guess the alternative would be to set the package list the same
> across all branches, even though they need different stuff, so they
> could share the same cache without fighting over it?

I don't think that'd work well either, imagine adding a new package to the
list...

The right approach probably is to include the list of packages in the key. A
bit annoying to change, because we'd need to move the list of packages to an
environment variable or file, but doable. I think something like

env:
  MACOS_PACKAGE_LIST: >-
    ccache
    icu
...
    fingerprint_script: |
      ...
      echo $MACOS_PACKAGE_LIST
    ...
  setup_additional_packages_script: |
    sh src/tools/ci/ci_macports_packages.sh $MACOS_PACKAGE_LIST

should work?


> For some reason CI is not allowing me to
> see the output from macOS right now (?!) so I couldn't see what
> "Populate macports cache" printed out[1], but I think this should be
> right... will try again tomorrow.

I can see it for your link at the momemnt, fwiw.

Greetings,

Andres Freund


Reply via email to