RE: Use __attribute__((target(sse4.2))) for SSE42 CRC32C

Thu, 21 Nov 2024 15:08:30 -0800 

> I think it is in pretty good shape.  After a read-through, the only thing 
> that stands
> out to me is the difference in configure tests between autoconf and meson.  I
> think we should consider picking one approach, although I'm not sure I have a
> strong preference.

Thanks for the review! We can actually leverage meson's built in option to 
check for a macro: cc.get_define('__SSE4_2__') != ''. This should keep the 
logic consistent across configure and meson.

Attachment: v4-0001-Use-__attribute__-target-sse4.2-for-SSE42-CRC32C.patch
Description: v4-0001-Use-__attribute__-target-sse4.2-for-SSE42-CRC32C.patch

Attachment: v4-0002-Use-consistent-logic-in-configure-and-meson-to-ge.patch
Description: v4-0002-Use-consistent-logic-in-configure-and-meson-to-ge.patch

Reply via email to