> On 15 Nov 2024, at 06:44, Masahiko Sawada <sawada.m...@gmail.com> wrote: > > IIUC v29 patch implements UUIDv7 generation in this way. So I've > reviewed v29 patch and here are some review comments:
I believe I've addressed all your comments in v31 with one exception: get_clock_timestamp_ns() does not return ascending values, because it resides in too generic place. So there's get_real_time_ns_ascending() in uuid.c. Should we make a note about get_clock_timestamp_ns() returning only microseconds somewhere? Also, maybe let's steal 2 random bits (from version or variant) and mix it into increased_clock_precision on MacOS? Thank you! Best regards, Andrey Borodin.
v31-0001-Implement-UUID-v7.patch
Description: Binary data
