On 11.11.24 08:53, Bertrand Drouvot wrote:
Maybe it would be better to push the assertion into get_object_address(),
something like
Assert(!relation || relp)
near the end.
That looks like a good idea to me, that would make the code cleaner and easier
to understand.
Meaning, if you pass NULL for the relp argument, then you
don't expect a relation. This is kind of what will happen now anyway,
except with a segfault instead of an assertion.
Yeah, I like it.
So, something like the attached (provided as .txt file to no mess up the CF bot
entry related to this thread) could be applied before?
Thanks. I have applied your patch and then also mine with the
appropriate adjustments.
