Dear Tomas,

Thanks for updating the patch.

I've tested new patch and confirmed the brin_pgage_items() could error out:

```
postgres=# SELECT * FROM brin_page_items(get_raw_page('foo_id_idx', 2), 
'foo_id_idx');
ERROR:  function has wrong number of declared columns
HINT:  To resolve the problem, update the "pageinspect" extension to the latest 
version.
```

I also do not have strong opinions for both approaches.
If I had to say... it's OK to do error out. The source becomes simpler and I 
cannot
find use-case that user strongly wants to use the older pageinspect extension.

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Reply via email to