Hi, On 2024-11-07 15:05:31 -0500, Jan Wieck wrote: > On 11/7/24 13:19, Andres Freund wrote: > > I think it's *completely* unacceptable to call a hook inside > > ReserveXLogInsertLocation, with the spinlock held, no less. That's the most > > contended section of code in postgres. > > Aside from your technical concerns, can we at least agree that the commit-ts > vs LSN inversion is a problem that should get addressed?
I'm not against addressing it, but I'd consider it not a high priority and that the acceptable cost (both runtime and maintenance) of it should would need to be extremely low. Greetings, Andres Freund
