On 29.10.24 23:33, Michael Paquier wrote:
On Tue, Oct 29, 2024 at 03:53:43PM +0100, Daniel Gustafsson wrote:
+1, I think this is a net improvement.
Agreed. I have spent some time looking in the past few years looking
at patches that tweaked this table, and it was always hard to figure
out if it was completely right.
The only thing I would change on top of this is move the reference to section
9.30 under table_rewrite to be at the end after both supporting functions since
the link is relevant to both of them. Something like:
- <literal>pg_event_trigger_table_rewrite_oid()</literal> (see
- <xref linkend="functions-event-triggers"/>). To discover the reason(s)
- for the rewrite, use the function
- <literal>pg_event_trigger_table_rewrite_reason()</literal>.
+ <literal>pg_event_trigger_table_rewrite_oid()</literal> To discover the
reason(s)
+ for the rewrite, use the function
<literal>pg_event_trigger_table_rewrite_reason()</literal>
+ (see <xref linkend="functions-event-triggers"/>).
Fine by me to tweak this paragraph like that with the link at the end.
Committed with the suggested changes.
