Hi, On Tue, Nov 05, 2024 at 05:08:41PM +1300, David Rowley wrote: > I was happy enough with my patch with Bertrand's comments. I'm not > sure why unsigned chars are better than chars. It doesn't seem to have > any effect on the compiled code. >
I think that unsigned chars is better than char for byte level memory operations (no sign extension issues). Though I agree that using char in this function is not an issue as p is only compared with 0. This is more a matter of taste here. Regards, -- Bertrand Drouvot PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
