On Fri, 1 Nov 2024 at 09:23, Peter Smith <smithpb2...@gmail.com> wrote: > > On Thu, Oct 31, 2024 at 3:16 AM vignesh C <vignes...@gmail.com> wrote: > > > Thanks for committing this patch, here is a rebased version of the > > remaining patches. > > > > Hi Vignesh. > > Here are my review comments for the docs patch v1-0002. > > ====== > Commit message > > 1. > This patch updates docs to describe the new feature allowing > replication of generated > columns. This includes addition of a new section "Generated Column > Replication" to the > "Logical Replication" documentation chapter. > > ~ > > That first sentence was correct previously when this patch contained > *all* the gencols documentation, but now some of the feature docs are > already handled by previous patches, so the first sentence can be > removed. > > Now patch 0002 is only for adding the new chapter, plus the references to it. > > ~ > > /This includes addition of a new section/This patch adds a new section/
Modified > ====== > doc/src/sgml/protocol.sgml > > 2. > <para> > - Next, one of the following submessages appears for each column > (except generated columns): > + Next, one of the following submessages appears for each column: > > AFAIK this simply cancels out a change from the v1-0001 patch which > IMO should have not been there in the first place. Please refer to my > v1-0001 review for the same. Removed it. The changes for the same are available at v47 version patch attached at [1]. I have not included the 0003 patch for now, I will include once these two patch stabilizes. [1] - https://www.postgresql.org/message-id/CALDaNm2sNfZoFfqOKq9GAjQZd3isqosij9iHaJjn7oQVmLLNYw%40mail.gmail.com Regards, Vignesh
