On Tue, Oct 29, 2024 at 02:06:11PM +0000, Bertrand Drouvot wrote: > Yeah, agree that it would make sense to document in the test what has been > discovered here.
How about something like the attached? -- Michael
diff --git a/src/test/modules/injection_points/specs/basic.spec b/src/test/modules/injection_points/specs/basic.spec
index 7f44e3ddc3..4a78fda64a 100644
--- a/src/test/modules/injection_points/specs/basic.spec
+++ b/src/test/modules/injection_points/specs/basic.spec
@@ -26,7 +26,11 @@ step wakeup2 { SELECT injection_points_wakeup('injection-points-wait'); }
step detach2 { SELECT injection_points_detach('injection-points-wait'); }
# Detach after wait and wakeup.
-# This permutation is proving to be unstable on FreeBSD, so disable for now.
+# Permutations like this one should be avoided, as it is not possible to
+# strictly control the timing when the SQL function doing the wait returns
+# back its result. In this case, the detach may finish faster than the
+# wait. It is recommended to use wakeups as the last permutation should
+# a wait be done within an SQL function.
#permutation wait1 wakeup2 detach2
# Detach before wakeup. s1 waits until wakeup, ignores the detach.
signature.asc
Description: PGP signature
