Hello. At Tue, 17 Jul 2018 13:37:59 +0900, Masahiko Sawada <sawada.m...@gmail.com> wrote in <cad21aocaddfxnwvhoakhbtpmry-0tfqoqh2nitx_ji15msn...@mail.gmail.com> > >> The usage of XLogSegNoOffsetToRecPtr is wrong. Since we specify the > >> destination at 4th argument the wal_segment_size will be changed in > >> the above expression. The regression tests by PostgreSQL Patch Tester > > > > I'm not sure I get this correctly, the definition of the macro is > > as follows. > > > > | #define XLogSegNoOffsetToRecPtr(segno, offset, dest, wal_segsz_bytes) \ > > | (dest) = (segno) * (wal_segsz_bytes) + (offset) > > > > The destination is the *3rd* parameter and the forth is segment > > size which is not to be written. > > Please see commit a22445ff0b which flipped input and output arguments. > So maybe you need to rebase the patches to current HEAD.
Mmm. Thanks. I never thought such change happned but it is accidentially took away in the latest patch. regards. -- Kyotaro Horiguchi NTT Open Source Software Center
