On Fri, 18 Oct 2024 at 5:24 PM, Amit Kapila <amit.kapil...@gmail.com> wrote:
> On Fri, Oct 18, 2024 at 9:48 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > On Tue, Oct 8, 2024 at 3:38 PM Amit Kapila <amit.kapil...@gmail.com> > wrote: > >> > >> On Tue, Oct 8, 2024 at 2:25 PM shveta malik <shveta.ma...@gmail.com> > wrote: > >> > > >> > On Mon, Oct 7, 2024 at 4:03 PM vignesh C <vignes...@gmail.com> wrote: > >> > > > >> > > >> > With parallel streaming as default, do you think there is a need to > >> > increase the default for 'max_logical_replication_workers' as IIUC > >> > parallel workers are taken from the same pool. > >> > > >> > >> Good question. But then one may say that we should proportionately > >> increase max_worker_processes as well. I don't know what should be > >> reasonable new defaults. I think we should make parallel streaming as > >> default and then wait for some user feedback before changing other > >> defaults. > >> > > > > I agree, actually streaming of in progress transactions is a useful > feature for performance in case of large transactions, so it makes sense to > make it "on" by default. So +1 from my side. > > > > Your response is confusing. AFAIU, this proposal is to change the > default value of the streaming option to 'parallel' but you are > suggesting to make 'on' as default which is different from the > proposed default but OTOH you are saying +1 as well. So, both can't be > true. Sorry for confusion I meant to say change default as ‘parallel’ — Dilip >
