On Sat, Oct 12, 2024 at 01:48:15AM +0200, Joel Jacobson wrote: > In passing, consistently use "stdin" for COPY FROM and "stdout" for COPY TO, > even though it has no effect on the tests per se, it seems > better to be consistent, to avoid confusion.
(Looking at v2.) -COPY x to stdin (format BINARY, delimiter ','); +COPY x to stdout (format BINARY, delimiter ',') Right. It does not matter because the option combinations are checked for TO and FROM in the same ProcessCopyOptions(). > [PATCH 2/2] Fix validation of FORCE_NOT_NULL/FORCE_NULL for > all-columns case. > > Add missing checks for FORCE_NOT_NULL and FORCE_NULL when applied to > all columns via "*". These options now correctly require CSV mode and > are disallowed in COPY TO as appropriate. Adjusted regression > tests to verify correct behavior for the all-columns case. You are right. f6d4c9cf162b got that wrong. Will fix and backpatch with the extra tests. -- Michael
signature.asc
Description: PGP signature
