Hello Peter, 11.09.2024 10:37, Peter Eisentraut wrote:
This has been committed.
I've discovered that starting from 0785d1b8b, make check -C src/bin/pg_combinebackup fails under Valgrind, with the following diagnostics: 2024-10-15 14:29:52.883 UTC [3338981] 002_compare_backups.pl STATEMENT: UPLOAD_MANIFEST ==00:00:00:20.028 3338981== Conditional jump or move depends on uninitialised value(s) ==00:00:00:20.028 3338981== at 0xA3E68F: json_lex (jsonapi.c:1496) ==00:00:00:20.028 3338981== by 0xA3ED13: json_lex (jsonapi.c:1666) ==00:00:00:20.028 3338981== by 0xA3D5AF: pg_parse_json_incremental (jsonapi.c:822) ==00:00:00:20.028 3338981== by 0xA40ECF: json_parse_manifest_incremental_chunk (parse_manifest.c:194) ==00:00:00:20.028 3338981== by 0x31656B: FinalizeIncrementalManifest (basebackup_incremental.c:237) ==00:00:00:20.028 3338981== by 0x73B4A4: UploadManifest (walsender.c:709) ==00:00:00:20.028 3338981== by 0x73DF4A: exec_replication_command (walsender.c:2185) ==00:00:00:20.028 3338981== by 0x7C58C3: PostgresMain (postgres.c:4762) ==00:00:00:20.028 3338981== by 0x7BBDA7: BackendMain (backend_startup.c:107) ==00:00:00:20.028 3338981== by 0x6CF60F: postmaster_child_launch (launch_backend.c:274) ==00:00:00:20.028 3338981== by 0x6D546F: BackendStartup (postmaster.c:3415) ==00:00:00:20.028 3338981== by 0x6D2B21: ServerLoop (postmaster.c:1648) ==00:00:00:20.028 3338981== (Initializing dummy_lex.inc_state = NULL; before partial_result = json_lex(&dummy_lex); makes these TAP tests pass for me.) Best regards, Alexander
