On Tue, 8 Oct 2024 21:37:38 -0700 "David G. Johnston" <david.g.johns...@gmail.com> wrote:
> On Tuesday, October 8, 2024, Tom Lane <t...@sss.pgh.pa.us> wrote: > > > "David G. Johnston" <david.g.johns...@gmail.com> writes: > > > On Tuesday, October 8, 2024, Yugo Nagata <nag...@sraoss.co.jp> wrote: > > >> On Wed, 09 Oct 2024 11:10:37 +0900 > > >> Shinya Kato <shinya11.k...@oss.nttdata.com> wrote: > > >>> When SQL scripts created with pg_dump/pg_dumpall/pg_restore are > > executed > > >>> in psql with AUTOCOMMIT turned off, they will not succeed in many > > cases. > > > > > Agreed. If we aren’t already outputting psql-only stuff I am a strong -1 > > > for making this the first such case. > > > > I really doubt that this is the only way in which you can break a > > pg_dump script by executing it in a non-default psql environment. > > We'd likely be better advised to spend some documentation effort > > recommending that pg_dump scripts be executed under "psql --no-psqlrc". > > > +1 > > Reinforcing that our output script basically assumes a default execution > environment seems worth mentioning even if it seems self-evident once it’s > said. +1 Regards, Yugo Nagata -- Yugo Nagata <nag...@sraoss.co.jp>
