Hi, On Tue, 8 Oct 2024 at 00:55, Heikki Linnakangas <hlinn...@iki.fi> wrote: > > On 05/10/2024 22:51, Dagfinn Ilmari Mannsåker wrote: > > Heikki Linnakangas <hlinn...@iki.fi> writes: > >> Sadly Windows' IO::Socket::UNIX hasn't been implemented on Windows (or > >> at least on this perl distribution we're using in Cirrus CI): > >> > >> Socket::pack_sockaddr_un not implemented on this architecture at > >> C:/strawberry/5.26.3.1/perl/lib/Socket.pm line 872. > >> > >> so I'll have to disable this test on Windows anyway. > > > > Socket version 2.028 (included in Perl 5.32) provides pack_sockaddr_un() > > on Windows, so that can be fixed by bumping the Perl version in > > https://github.com/anarazel/pg-vm-images/blob/main/packer/windows.pkr.hcl > > to something more modern (such as 5.40.0.1), and only skipping the test > > if on Windows if Socket is too old. > > > > The decision to use 5.26 seems to come from the initial creation of the > > CI images in 2021 (when 5.34 was current), with the comment «newer > > versions don't currently work correctly for plperl». That claim is > > worth revisiting, and fixing if it's still the case. > > Yeah, it would be nice to update it. I wonder if commit > 341f4e002d461a3c5513cb864490cddae2b43a64 fixed whatever the problem was.
The perl version in Windows CI image is bumped to 5.40.0.1 [1]. So, the related test passes on Windows now [2]. [1] https://github.com/anarazel/pg-vm-images/commit/cbd5d46f2fb7b28efb126ddac64d12711247dfa8 [2] https://cirrus-ci.com/task/5682393120505856?logs=check_world#L241 -- Regards, Nazir Bilal Yavuz Microsoft
