On Mon, Sep 30, 2024 at 02:20:21PM +0900, Yugo NAGATA wrote:
> On Sat, 28 Sep 2024 21:19:11 -0400
> Bruce Momjian <br...@momjian.us> wrote:
> 
> > On Thu, Sep 26, 2024 at 02:19:21PM +0900, Yugo Nagata wrote:
> > > On Thu, 9 May 2024 00:03:50 -0400
> > > Bruce Momjian <br...@momjian.us> wrote:
> > > 
> > > > I have committed the first draft of the PG 17 release notes;  you can
> > > > see the results here:
> > > 
> > > I propose to improve the following description in "Migration to Version 
> > > 17"
> > > section by adding CREATE INDEX and CREATE MATERIALIZED VIEW into the 
> > > command list.
> > > 
> > >      <para>
> > >      Change functions to use a safe <xref linkend="guc-search-path"/>
> > >      during maintenance operations (Jeff Davis)
> > >      <ulink url="&commit_baseurl;2af07e2f7">&sect;</ulink>
> > >      </para>
> > > 
> > > It is suggested in the thread [1] that users could not notice the 
> > > behaviour
> > > of CREATE INDEX is changed because the explicit command name is not 
> > > listed in
> > > the release notes. So, I think it is better to add CREATE INDEX and
> > > CREATE MATERIALIZED VIEW into the command list. 
> > > 
> > > I've attached a patch.
> > 
> > It this a valid change?  Seems so.
> 
> Yes. This change on CREATE INDEX was introduced by 2af07e2f7 together with
> other commands, but it was missed to be mentioned in the commit message
> although the description was added to the documentation.
> 
> The change on CEATE MATERIALIZED VIEW was introduced by a separate commit
> b4da732fd, since which the REFRESH logic is used when creating a matview.
> Should we add here a link to that commit, too?

I developed the attached patch which adds the two commands and the
commit item.

-- 
  Bruce Momjian  <br...@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  When a patient asks the doctor, "Am I going to die?", he means 
  "Am I going to die soon?"
diff --git a/doc/src/sgml/release-17.sgml b/doc/src/sgml/release-17.sgml
index ad814737745..7acdee05e42 100644
--- a/doc/src/sgml/release-17.sgml
+++ b/doc/src/sgml/release-17.sgml
@@ -125,6 +125,8 @@
 <!--
 Author: Jeff Davis <jda...@postgresql.org>
 2024-03-04 [2af07e2f7] Fix search_path to a safe value during maintenance opera
+Author: Jeff Davis <jda...@postgresql.org>
+2024-07-16 [b4da732fd64] When creating materialized views, use REFRESH to load data.
 -->
 
     <listitem>
@@ -136,7 +138,9 @@ Author: Jeff Davis <jda...@postgresql.org>
 
      <para>
      This prevents maintenance operations (<command>ANALYZE</command>,
-     <command>CLUSTER</command>, <command>REFRESH
+     <command>CLUSTER</command>, <command>CREATE
+     INDEX</command>, <command>CREATE
+     MATERIALIZED VIEW</command>, <command>REFRESH
      MATERIALIZED VIEW</command>, <command>REINDEX</command>,
      or <command>VACUUM</command>) from performing unsafe access.
      Functions used by expression indexes and materialized views that

Reply via email to