On Thu, Sep 26, 2024 at 2:57 PM Jelte Fennema-Nio <postg...@jeltef.nl> wrote: > On Thu, 26 Sept 2024 at 08:06, Robert Haas <robertmh...@gmail.com> wrote: > > Focusing on the first patch seems odd to me, though > > Indeed the first few patches will often be small, and the big patch > will appear later. When I split patches up, those small patches should > usually be reviewable without looking at the big patch in detail, and > hopefully they shouldn't be too contentious: e.g. a comment > improvement or some small refactor. But often those patches don't seem > to be reviewed significantly quicker or merged significantly earlier > than the big patch. That makes it seem to me that even though they > should be relatively low-risk to commit and low-effort to review, > reviewers are scared away by the sheer number of patches in the > patchset, or by the size of the final patch. That's why I thought it > could be useful to specifically show the size of the first patch in > addition to the total patchset size, so that reviewers can easily spot > some small hopefully easy to review patch at the start of a patchset.
Fair enough! Personally what I'd want to know is how large the biggest patch is, but I see your point, too. -- Robert Haas EDB: http://www.enterprisedb.com
