On Fri, Sep 13, 2024 at 03:56:11PM +0900, Yugo Nagata wrote: > I confirmed the patches are committed in the master branch. > Thank you! > > I've updated the commitfest status to "committed".
This patch has been committed as of 4eada203a5a8, and introduced this
block in pg_proc.dat:
{ oid => '4551', descr => 'user privilege on large objct by username, large
object oid',
proname => 'has_largeobject_privilege', procost => '10', provolatile => 's',
prorettype => 'bool', proargtypes => 'name oid text',
prosrc => 'has_largeobject_privilege_name_id' },
{ oid => '4552', descr => 'current privilege on large objct by large object
oid',
proname => 'has_largeobject_privilege', procost => '10', provolatile => 's',
prorettype => 'bool', proargtypes => 'oid text',
prosrc => 'has_largeobject_privilege_id' },
{ oid => '4553', descr => 'user privilege on large objct by user oid, large
object oid',
proname => 'has_largeobject_privilege', procost => '10', provolatile => 's',
prorettype => 'bool', proargtypes => 'oid oid text',
prosrc => 'has_largeobject_privilege_id_id' },
This has a couple of mistakes:
- New functions introduced during a development cycle should use OIDs in
the range 8000-9999. See 98eab30b93d5, consisting of running
./unused_oids to get a random range.
- The function descriptions are inconsistent and have the three same
typos:
-- s/large objct/large object/.
-- s/current privilege/current user privilege/ for the second entry.
And while that's not mandatory for committers, I would apply a
reformat-dat-files while on it, to reduce some diffs I'm seeing.
This results in the attached that I'd like to apply to fix all that. It
needs a catalog version bump, of course.
--
Michael
From a2b886a277a9f4a0e4059f53ff78631d8e9e2abb Mon Sep 17 00:00:00 2001
From: Michael Paquier <mich...@paquier.xyz>
Date: Thu, 26 Sep 2024 17:14:45 +0900
Subject: [PATCH] Fix inconsistencies with catalog data of new LO privilege
functions
XXX: catversion bump!!
---
src/include/catalog/pg_proc.dat | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat
index 43f608d7a0..72bc4daed3 100644
--- a/src/include/catalog/pg_proc.dat
+++ b/src/include/catalog/pg_proc.dat
@@ -5369,15 +5369,18 @@
prorettype => 'bool', proargtypes => 'oid text',
prosrc => 'has_any_column_privilege_id' },
-{ oid => '4551', descr => 'user privilege on large objct by username, large object oid',
+{ oid => '8048',
+ descr => 'user privilege on large object by username, large object oid',
proname => 'has_largeobject_privilege', procost => '10', provolatile => 's',
prorettype => 'bool', proargtypes => 'name oid text',
prosrc => 'has_largeobject_privilege_name_id' },
-{ oid => '4552', descr => 'current privilege on large objct by large object oid',
+{ oid => '8049',
+ descr => 'current user privilege on large object by large object oid',
proname => 'has_largeobject_privilege', procost => '10', provolatile => 's',
prorettype => 'bool', proargtypes => 'oid text',
prosrc => 'has_largeobject_privilege_id' },
-{ oid => '4553', descr => 'user privilege on large objct by user oid, large object oid',
+{ oid => '8050',
+ descr => 'user privilege on large object by user oid, large object oid',
proname => 'has_largeobject_privilege', procost => '10', provolatile => 's',
prorettype => 'bool', proargtypes => 'oid oid text',
prosrc => 'has_largeobject_privilege_id_id' },
--
2.45.2
signature.asc
Description: PGP signature
